Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of remark-rehype options #445

Closed
wants to merge 2 commits into from
Closed

Conversation

gtnbssn
Copy link
Contributor

@gtnbssn gtnbssn commented May 5, 2022

This documents how to use the changes made in withastro/astro#3297 in order to close withastro/astro#3163

This documents how to use the changes made in withastro/astro#3297 in order to close withastro/astro#3163
@netlify
Copy link

netlify bot commented May 5, 2022

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f73d41d
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6278a42e2dc8840007ecaccb
😎 Deploy Preview https://deploy-preview-445--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@delucis delucis marked this pull request as draft May 9, 2022 17:15
@delucis
Copy link
Member

delucis commented May 9, 2022

Thanks @gtnbssn! I’ve marked this as a draft so we don’t accidentally merge this before withastro/astro#3297 is merged. Please mark this as ready to review when that happens 🙌

@sarah11918 sarah11918 added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label May 9, 2022
@sarah11918
Copy link
Member

Hi @gtnbssn ! I'm just going through the older PRs still marked as drafts, and I can see that the original PR for the changes to astro core repository hasn't seen any activity in a while.

Just pinging you to put this back on your radar, and wondering whether those changes are in fact coming still that will require this documentation? It's fine to let this sit as a draft, but I did want to make sure we know what's happening here. :)

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. tsc guidance required from Technical Steering Committee and removed improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) labels Jul 5, 2022
@gtnbssn
Copy link
Contributor Author

gtnbssn commented Jul 6, 2022

Hi @sarah11918 ! I have updated my PR, let's see if this gets merged!

@delucis
Copy link
Member

delucis commented Jul 12, 2022

Just noticed withastro/astro#3297 was closed, so closing this to match. As the comment says there — feel free to re-open if that PR sees some movement. Thanks for this nevertheless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. tsc guidance required from Technical Steering Committee
Projects
None yet
3 participants